Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing trailing newline before adding new entry with set_key #361

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

bbc2
Copy link
Collaborator

@bbc2 bbc2 commented Oct 23, 2021

Sometimes, the source file doesn't have a trailing newline. If we add a new binding in such a case, we need to add a newline before the new binding.

Closes #360.

@bbc2 bbc2 self-assigned this Oct 23, 2021
Sometimes, the source file doesn't have a trailing newline.  If we add a
new binding in such a case, we need to add a newline before the new
binding.
@ethsanders
Copy link

@theskumar, why has this not yet been merged?

@bbc2
Copy link
Collaborator Author

bbc2 commented Nov 11, 2021

I don't know the reason but I have to mention that we maintain this package in our spare time, so we're not always available to do code reviews.

In my case, I like to leave my MRs open for a while so that other developers get a chance to comment on them. I think this one has waited long enough so I'm going to merge it.

@bbc2 bbc2 merged commit 45848bb into theskumar:master Nov 11, 2021
@bbc2 bbc2 deleted the add-missing-newline branch November 11, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_key does not check if there is a carriage return before inserting new key
2 participants